[
https://issues.apache.org/jira/browse/KYLIN-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693017#comment-16693017
]
ASF GitHub Bot commented on KYLIN-3669:
---------------------------------------
asfgit commented on issue #352: KYLIN-3669, add log to indicate the case when
using "GTStreamAggregateScanner".
URL: https://github.com/apache/kylin/pull/352#issuecomment-440223647
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add log to GTStreamAggregateScanner
> -----------------------------------
>
> Key: KYLIN-3669
> URL: https://issues.apache.org/jira/browse/KYLIN-3669
> Project: Kylin
> Issue Type: Improvement
> Components: Query Engine
> Reporter: Jiatao Tao
> Assignee: Jiatao Tao
> Priority: Trivial
>
> There's no log printing in GTStreamAggregateScanner, and you know nothing
> about whether you go to this path or not, it's pretty unfriendly for trouble
> shooting.
> Code in _SegmentCubeTupleIterator_.
> {code:java}
> boolean hasMultiplePartitions = records instanceof
> SortMergedPartitionResultIterator;
> if (hasMultiplePartitions && context.isStreamAggregateEnabled()) {
> ...
> // input records are ordered, leverage stream aggregator to produce
> possibly fewer records
> try (GTStreamAggregateScanner aggregator = new
> GTStreamAggregateScanner(inputScanner, scanRequest)) {
> result = aggregator.valuesIterator(gtDimsIdx, gtMetricsIdx);
> } catch (IOException ioe) {
> // implementation of close method of anonymous IGTScanner is empty,
> no way throw exception
> throw new IllegalStateException("IOException is not expected here.",
> ioe);
> }
> return result;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
