[ 
https://issues.apache.org/jira/browse/KYLIN-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701336#comment-16701336
 ] 

ASF subversion and git services commented on KYLIN-3669:
--------------------------------------------------------

Commit 48a2bec01caa7b764d55bfa74b3da5a4936c598d in kylin's branch 
refs/heads/2.5.x-hadoop3.1 from [~Aron.tao]
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=48a2bec ]

KYLIN-3669, add log to indicate the case when using GTStreamAggregateScanner.


> Add log to GTStreamAggregateScanner
> -----------------------------------
>
>                 Key: KYLIN-3669
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3669
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Query Engine
>            Reporter: Jiatao Tao
>            Assignee: Jiatao Tao
>            Priority: Trivial
>             Fix For: v2.5.2
>
>
> There's no log printing in GTStreamAggregateScanner, and you know nothing 
> about whether you go to this path or not, it's pretty unfriendly for trouble 
> shooting.
> Code in _SegmentCubeTupleIterator_.
> {code:java}
> boolean hasMultiplePartitions = records instanceof 
> SortMergedPartitionResultIterator;
> if (hasMultiplePartitions && context.isStreamAggregateEnabled()) {
>     ...
>     // input records are ordered, leverage stream aggregator to produce 
> possibly fewer records
>     try (GTStreamAggregateScanner aggregator = new 
> GTStreamAggregateScanner(inputScanner, scanRequest)) {
>         result = aggregator.valuesIterator(gtDimsIdx, gtMetricsIdx);
>     } catch (IOException ioe) {
>         // implementation of close method of anonymous IGTScanner is empty, 
> no way throw exception
>         throw new IllegalStateException("IOException is not expected here.", 
> ioe);
>     }
>     return result;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to