[
https://issues.apache.org/jira/browse/KYLIN-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699349#comment-16699349
]
ASF GitHub Bot commented on KYLIN-3700:
---------------------------------------
codecov-io commented on issue #362: KYLIN-3700 Quote sql identities when
creating flat table
URL: https://github.com/apache/kylin/pull/362#issuecomment-441728994
# [Codecov](https://codecov.io/gh/apache/kylin/pull/362?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@70f15d7`). [Click here to learn what that
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `22.14%`.
[](https://codecov.io/gh/apache/kylin/pull/362?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #362 +/- ##
=========================================
Coverage ? 23.58%
Complexity ? 4838
=========================================
Files ? 1134
Lines ? 68344
Branches ? 9705
=========================================
Hits ? 16122
Misses ? 50656
Partials ? 1566
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/362?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...k/datasource/framework/SourceConnectorFactory.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2ZyYW1ld29yay9Tb3VyY2VDb25uZWN0b3JGYWN0b3J5LmphdmE=)
| `57.89% <ø> (ø)` | `1 <0> (?)` | |
|
[...java/org/apache/kylin/metadata/model/TableRef.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVSZWYuamF2YQ==)
| `51.16% <0%> (ø)` | `11 <0> (?)` | |
|
[...ain/java/org/apache/kylin/job/JoinedFlatTable.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9Kb2luZWRGbGF0VGFibGUuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...ava/org/apache/kylin/metadata/model/TableDesc.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVEZXNjLmphdmE=)
| `46.01% <0%> (ø)` | `27 <0> (?)` | |
|
[...pache/kylin/source/hive/GarbageCollectionStep.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0dhcmJhZ2VDb2xsZWN0aW9uU3RlcC5qYXZh)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...a/org/apache/kylin/common/util/HiveCmdBuilder.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hpdmVDbWRCdWlsZGVyLmphdmE=)
| `83.33% <100%> (ø)` | `12 <0> (?)` | |
|
[.../kylin/source/jdbc/extensible/JdbcHiveMRInput.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL2V4dGVuc2libGUvSmRiY0hpdmVNUklucHV0LmphdmE=)
| `89.79% <100%> (ø)` | `3 <0> (?)` | |
|
[...e/kylin/sdk/datasource/adaptor/DefaultAdaptor.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2FkYXB0b3IvRGVmYXVsdEFkYXB0b3IuamF2YQ==)
| `21.34% <2.63%> (ø)` | `12 <0> (?)` | |
|
[.../apache/kylin/job/util/FlatTableSqlQuoteUtils.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi91dGlsL0ZsYXRUYWJsZVNxbFF1b3RlVXRpbHMuamF2YQ==)
| `21% <21%> (ø)` | `8 <8> (?)` | |
|
[...in/sdk/datasource/adaptor/AbstractJdbcAdaptor.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2FkYXB0b3IvQWJzdHJhY3RKZGJjQWRhcHRvci5qYXZh)
| `51.04% <22.22%> (ø)` | `14 <2> (?)` | |
| ... and [6
more](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/362?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/362?src=pr&el=footer). Last
update
[70f15d7...5811252](https://codecov.io/gh/apache/kylin/pull/362?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Quote sql identities when creating flat table
> ---------------------------------------------
>
> Key: KYLIN-3700
> URL: https://issues.apache.org/jira/browse/KYLIN-3700
> Project: Kylin
> Issue Type: Improvement
> Components: RDBMS Source
> Affects Versions: v2.5.1
> Reporter: XiaoXiang Yu
> Assignee: XiaoXiang Yu
> Priority: Major
> Fix For: v2.6.0
>
>
> *When kyin operate with different data source, DDL/DML may be broken because
> datasource has some different specific reserved keyword.*
>
> Sql identity should be quoted when:
> 1) Create flat table.
> 2) Push down to different datasource (different RDBMS has different reserved
> keyword) .
>
> {code:java}
> 2018-10-05 03:05:04,143 ERROR [pool-25-thread-2] conv.SqlConverter : Failed
> to default convert sql, will use the input: SELECT COUNT(TIME_KEY), TIME_KEY
> FROM CUBE.OPERATIONS_TIME WHERE TIME_KEY IS NOT NULL GROUP BY TIME_KEY ORDER
> BY COUNT(TIME_KEY) DESC LIMIT 10
> org.apache.calcite.sql.parser.SqlParseException: Encountered "FROM CUBE" at
> line 1, column 34.
> Was expecting one of:
> <EOF>
> "ORDER" ...
> "LIMIT" ...
> "OFFSET" ...
> "FETCH" ...
> "FROM" <IDENTIFIER> ...
> "FROM" <QUOTED_IDENTIFIER> ...
> "FROM" <BACK_QUOTED_IDENTIFIER> ...
> "FROM" <BRACKET_QUOTED_IDENTIFIER> ...
> "FROM" <UNICODE_QUOTED_IDENTIFIER> ...
> "FROM" "LATERAL" ...
> "FROM" "(" ...
> "FROM" "UNNEST" ...
> "FROM" "TABLE" ...
> "," ...
> "AS" ...
> <IDENTIFIER> ...
> <QUOTED_IDENTIFIER> ...
> <BACK_QUOTED_IDENTIFIER> ...
> <BRACKET_QUOTED_IDENTIFIER> ...
> <UNICODE_QUOTED_IDENTIFIER> ...
> "." ...
> "INTERSECT" ...
> "EXCEPT" ...
> "MINUS" ...
> "(" ...
>
> at
> org.apache.calcite.sql.parser.impl.SqlParserImpl.convertException(SqlParserImpl.java:349)
> at
> org.apache.calcite.sql.parser.impl.SqlParserImpl.normalizeException(SqlParserImpl.java:130){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
