[
https://issues.apache.org/jira/browse/KYLIN-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701445#comment-16701445
]
ASF GitHub Bot commented on KYLIN-3700:
---------------------------------------
codecov-io edited a comment on issue #362: KYLIN-3700 Quote sql identities when
creating flat table
URL: https://github.com/apache/kylin/pull/362#issuecomment-441728994
# [Codecov](https://codecov.io/gh/apache/kylin/pull/362?src=pr&el=h1) Report
> Merging [#362](https://codecov.io/gh/apache/kylin/pull/362?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/97ee98bfbd93510b578db93998f2ab488199ef40?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `27.86%`.
[](https://codecov.io/gh/apache/kylin/pull/362?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #362 +/- ##
============================================
- Coverage 23.63% 23.63% -0.01%
- Complexity 4828 4837 +9
============================================
Files 1130 1131 +1
Lines 68023 68193 +170
Branches 9657 9684 +27
============================================
+ Hits 16079 16119 +40
- Misses 50377 50507 +130
Partials 1567 1567
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/362?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...k/datasource/framework/SourceConnectorFactory.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2ZyYW1ld29yay9Tb3VyY2VDb25uZWN0b3JGYWN0b3J5LmphdmE=)
| `57.89% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
|
[...java/org/apache/kylin/metadata/model/TableRef.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVSZWYuamF2YQ==)
| `51.16% <0%> (-1.22%)` | `11 <0> (ø)` | |
|
[...ain/java/org/apache/kylin/job/JoinedFlatTable.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9Kb2luZWRGbGF0VGFibGUuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...ava/org/apache/kylin/metadata/model/TableDesc.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVEZXNjLmphdmE=)
| `46.01% <0%> (-1.76%)` | `27 <0> (ø)` | |
|
[...pache/kylin/source/hive/GarbageCollectionStep.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0dhcmJhZ2VDb2xsZWN0aW9uU3RlcC5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...a/org/apache/kylin/common/util/HiveCmdBuilder.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hpdmVDbWRCdWlsZGVyLmphdmE=)
| `83.33% <100%> (ø)` | `12 <0> (ø)` | :arrow_down: |
|
[.../kylin/source/jdbc/extensible/JdbcHiveMRInput.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL2V4dGVuc2libGUvSmRiY0hpdmVNUklucHV0LmphdmE=)
| `89.79% <100%> (+0.9%)` | `3 <0> (ø)` | :arrow_down: |
|
[...e/kylin/sdk/datasource/adaptor/DefaultAdaptor.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2FkYXB0b3IvRGVmYXVsdEFkYXB0b3IuamF2YQ==)
| `32.71% <19.35%> (-3.38%)` | `12 <1> (ø)` | |
|
[.../apache/kylin/job/util/FlatTableSqlQuoteUtils.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi91dGlsL0ZsYXRUYWJsZVNxbFF1b3RlVXRpbHMuamF2YQ==)
| `21% <21%> (ø)` | `8 <8> (?)` | |
|
[...in/sdk/datasource/adaptor/AbstractJdbcAdaptor.java](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree#diff-ZGF0YXNvdXJjZS1zZGsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Nkay9kYXRhc291cmNlL2FkYXB0b3IvQWJzdHJhY3RKZGJjQWRhcHRvci5qYXZh)
| `51.04% <22.22%> (-3.18%)` | `14 <2> (+1)` | |
| ... and [10
more](https://codecov.io/gh/apache/kylin/pull/362/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/362?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/362?src=pr&el=footer). Last
update
[97ee98b...f981778](https://codecov.io/gh/apache/kylin/pull/362?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Quote sql identities when creating flat table
> ---------------------------------------------
>
> Key: KYLIN-3700
> URL: https://issues.apache.org/jira/browse/KYLIN-3700
> Project: Kylin
> Issue Type: Improvement
> Components: RDBMS Source
> Affects Versions: v2.5.1
> Reporter: XiaoXiang Yu
> Assignee: XiaoXiang Yu
> Priority: Major
> Fix For: v2.6.0
>
>
> *When kyin operate with different data source, DDL/DML may be broken because
> datasource has some different specific reserved keyword.*
>
> Sql identity should be quoted when:
> 1) Create flat table.
> 2) Push down to different datasource (different RDBMS has different reserved
> keyword) .
>
> {code:java}
> 2018-10-05 03:05:04,143 ERROR [pool-25-thread-2] conv.SqlConverter : Failed
> to default convert sql, will use the input: SELECT COUNT(TIME_KEY), TIME_KEY
> FROM CUBE.OPERATIONS_TIME WHERE TIME_KEY IS NOT NULL GROUP BY TIME_KEY ORDER
> BY COUNT(TIME_KEY) DESC LIMIT 10
> org.apache.calcite.sql.parser.SqlParseException: Encountered "FROM CUBE" at
> line 1, column 34.
> Was expecting one of:
> <EOF>
> "ORDER" ...
> "LIMIT" ...
> "OFFSET" ...
> "FETCH" ...
> "FROM" <IDENTIFIER> ...
> "FROM" <QUOTED_IDENTIFIER> ...
> "FROM" <BACK_QUOTED_IDENTIFIER> ...
> "FROM" <BRACKET_QUOTED_IDENTIFIER> ...
> "FROM" <UNICODE_QUOTED_IDENTIFIER> ...
> "FROM" "LATERAL" ...
> "FROM" "(" ...
> "FROM" "UNNEST" ...
> "FROM" "TABLE" ...
> "," ...
> "AS" ...
> <IDENTIFIER> ...
> <QUOTED_IDENTIFIER> ...
> <BACK_QUOTED_IDENTIFIER> ...
> <BRACKET_QUOTED_IDENTIFIER> ...
> <UNICODE_QUOTED_IDENTIFIER> ...
> "." ...
> "INTERSECT" ...
> "EXCEPT" ...
> "MINUS" ...
> "(" ...
>
> at
> org.apache.calcite.sql.parser.impl.SqlParserImpl.convertException(SqlParserImpl.java:349)
> at
> org.apache.calcite.sql.parser.impl.SqlParserImpl.normalizeException(SqlParserImpl.java:130){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
