[
https://issues.apache.org/jira/browse/KYLIN-3671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702754#comment-16702754
]
ASF GitHub Bot commented on KYLIN-3671:
---------------------------------------
codecov-io commented on issue #367: KYLIN-3671 Improve ResourceTool and
JDBCResourceStore's performance
URL: https://github.com/apache/kylin/pull/367#issuecomment-442716574
# [Codecov](https://codecov.io/gh/apache/kylin/pull/367?src=pr&el=h1) Report
> Merging [#367](https://codecov.io/gh/apache/kylin/pull/367?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/be5df4a8bb6939c0c62c6135c4312fe3ad56775d?src=pr&el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `18.23%`.
[](https://codecov.io/gh/apache/kylin/pull/367?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #367 +/- ##
============================================
+ Coverage 23.63% 23.65% +0.01%
- Complexity 4837 4876 +39
============================================
Files 1131 1134 +3
Lines 68193 68610 +417
Branches 9684 9744 +60
============================================
+ Hits 16119 16230 +111
- Misses 50507 50792 +285
- Partials 1567 1588 +21
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/367?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[.../java/org/apache/kylin/common/util/HadoopUtil.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hhZG9vcFV0aWwuamF2YQ==)
| `17.85% <ø> (ø)` | `10 <0> (ø)` | :arrow_down: |
|
[...che/kylin/storage/hbase/util/CubeMigrationCLI.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL0N1YmVNaWdyYXRpb25DTEkuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...a/org/apache/kylin/tool/ExtendCubeToHybridCLI.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9FeHRlbmRDdWJlVG9IeWJyaWRDTEkuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...n/java/org/apache/kylin/tool/CubeMetaIngester.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9DdWJlTWV0YUluZ2VzdGVyLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...apache/kylin/engine/mr/common/CubeStatsReader.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0N1YmVTdGF0c1JlYWRlci5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...n/java/org/apache/kylin/tool/CubeMigrationCLI.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9DdWJlTWlncmF0aW9uQ0xJLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[.../java/org/apache/kylin/rest/job/HybridCubeCLI.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL0h5YnJpZEN1YmVDTEkuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[.../apache/kylin/cube/cli/CubeSignatureRefresher.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9DdWJlU2lnbmF0dXJlUmVmcmVzaGVyLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...he/kylin/common/persistence/JDBCResourceStore.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9KREJDUmVzb3VyY2VTdG9yZS5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...e/kylin/engine/mr/steps/MergeDictionaryMapper.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvTWVyZ2VEaWN0aW9uYXJ5TWFwcGVyLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [43
more](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/367?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/367?src=pr&el=footer). Last
update
[be5df4a...ad8b780](https://codecov.io/gh/apache/kylin/pull/367?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve ResourceTool and JDBCResourceStore's performance
> --------------------------------------------------------
>
> Key: KYLIN-3671
> URL: https://issues.apache.org/jira/browse/KYLIN-3671
> Project: Kylin
> Issue Type: Improvement
> Components: Metadata
> Affects Versions: v2.5.0
> Reporter: Jinfeng Wu
> Assignee: Lijun Cao
> Priority: Minor
> Fix For: v2.6.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> 1.Set TRANSACTION_READ_COMMITTED as default isolation level in
> JDBCResourceStore for best performance.
> 2.Support to get metadata resource in bulk & use ”visitFolderAndContent“
> method to get metadata by folder.
> 3.Use Multithreading to download and upload metadata.
> 4.U can see the progress bar if u use metastore.sh to backup or restore
> metadata.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)