[ 
https://issues.apache.org/jira/browse/KYLIN-3671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712188#comment-16712188
 ] 

ASF GitHub Bot commented on KYLIN-3671:
---------------------------------------

codecov-io edited a comment on issue #367: KYLIN-3671 Improve ResourceTool and 
JDBCResourceStore's performance
URL: https://github.com/apache/kylin/pull/367#issuecomment-442716574
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/367?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@2979f40`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `18.36%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/367/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/367?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #367   +/-   ##
   =========================================
     Coverage          ?   23.65%           
     Complexity        ?     4879           
   =========================================
     Files             ?     1134           
     Lines             ?    68611           
     Branches          ?     9745           
   =========================================
     Hits              ?    16227           
     Misses            ?    50796           
     Partials          ?     1588
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/367?src=pr&el=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[.../java/org/apache/kylin/common/util/HadoopUtil.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hhZG9vcFV0aWwuamF2YQ==)
 | `17.85% <ø> (ø)` | `10 <0> (?)` | |
   | 
[...che/kylin/storage/hbase/util/CubeMigrationCLI.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS91dGlsL0N1YmVNaWdyYXRpb25DTEkuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...a/org/apache/kylin/tool/ExtendCubeToHybridCLI.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9FeHRlbmRDdWJlVG9IeWJyaWRDTEkuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...n/java/org/apache/kylin/tool/CubeMetaIngester.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9DdWJlTWV0YUluZ2VzdGVyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...apache/kylin/engine/mr/common/CubeStatsReader.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0N1YmVTdGF0c1JlYWRlci5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...n/java/org/apache/kylin/tool/CubeMigrationCLI.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9DdWJlTWlncmF0aW9uQ0xJLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[.../java/org/apache/kylin/rest/job/HybridCubeCLI.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL0h5YnJpZEN1YmVDTEkuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[.../apache/kylin/cube/cli/CubeSignatureRefresher.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NsaS9DdWJlU2lnbmF0dXJlUmVmcmVzaGVyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...he/kylin/common/persistence/JDBCResourceStore.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9KREJDUmVzb3VyY2VTdG9yZS5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...e/kylin/engine/mr/steps/MergeDictionaryMapper.java](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvTWVyZ2VEaWN0aW9uYXJ5TWFwcGVyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | ... and [34 
more](https://codecov.io/gh/apache/kylin/pull/367/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/367?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/367?src=pr&el=footer). Last 
update 
[2979f40...f4cab16](https://codecov.io/gh/apache/kylin/pull/367?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Improve ResourceTool and JDBCResourceStore's performance
> --------------------------------------------------------
>
>                 Key: KYLIN-3671
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3671
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Metadata
>    Affects Versions: v2.5.0
>            Reporter: Jinfeng Wu
>            Assignee: Lijun Cao
>            Priority: Minor
>             Fix For: v2.6.0
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> 1.Set TRANSACTION_READ_COMMITTED as default isolation level in 
> JDBCResourceStore for best performance.
> 2.Support to get metadata resource in bulk & use ”visitFolderAndContent“ 
> method to get metadata by folder.
> 3.Use Multithreading to download and upload metadata.
> 4.U can see the progress bar if u use metastore.sh to backup or restore 
> metadata.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to