nichunen commented on a change in pull request #568: KYLIN-3841 Build Global 
Dict by Hive
URL: https://github.com/apache/kylin/pull/568#discussion_r272098449
 
 

 ##########
 File path: 
source-hive/src/main/java/org/apache/kylin/source/hive/BeelineHiveClient.java
 ##########
 @@ -123,6 +124,26 @@ public long getHiveTableRows(String database, String 
tableName) throws Exception
         return count;
     }
 
+    @Override
+    public List<Object[]> getHiveResult(String hql) throws Exception {
+        ResultSet resultSet = null;
+        List<Object[]> datas = new ArrayList<>();
+        try {
+            resultSet = stmt.executeQuery(hql);
+            int columnCtn = resultSet.getMetaData().getColumnCount();
 
 Review comment:
   should be cnt?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to