nichunen commented on a change in pull request #568: KYLIN-3841 Build Global
Dict by Hive
URL: https://github.com/apache/kylin/pull/568#discussion_r272095367
##########
File path:
engine-mr/src/main/java/org/apache/kylin/engine/mr/common/BaseCuboidBuilder.java
##########
@@ -87,6 +108,23 @@ public BaseCuboidBuilder(KylinConfig kylinConfig, CubeDesc
cubeDesc, CubeSegment
measureCodec = new BufferedMeasureCodec(measureDescList);
kvBuilder = new KeyValueBuilder(intermediateTableDesc);
+
+ Set<String> mrDictColumnSet = new HashSet<>();
+ if (kylinConfig.getMrHiveDictColumns() != null) {
Review comment:
duplicate code, why not in a method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
