hit-lacus commented on a change in pull request #747: KYLIN-3832 Query pushdown
support postgresql
URL: https://github.com/apache/kylin/pull/747#discussion_r339345626
##########
File path:
core-job/src/main/java/org/apache/kylin/job/util/FlatTableSqlQuoteUtils.java
##########
@@ -54,25 +55,29 @@ private static synchronized void setQuote() {
}
public static String getQuote() {
- setQuote();
- return quote;
+ if
(kylinConfig.getJdbcSourceDialect().equals(SourceDialect.POSTGRESQL.source)) {
+ return "";
Review comment:
It is looks strange here, as far as I know, postgresql us double quote(") to
quote identifier.
Force disable quote with hard code seems not be a good practice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
