hit-lacus commented on a change in pull request #747: KYLIN-3832 Query pushdown
support postgresql
URL: https://github.com/apache/kylin/pull/747#discussion_r339346253
##########
File path:
source-jdbc/src/main/java/org/apache/kylin/source/jdbc/extensible/JdbcHiveInputBase.java
##########
@@ -101,7 +111,9 @@ protected AbstractExecutable
createSqoopToFlatHiveStep(String jobWorkingDir, Str
}
bquery = escapeQuotationInSql(bquery);
- splitColumn =
escapeQuotationInSql(dataSource.convertColumn(splitColumn,
FlatTableSqlQuoteUtils.getQuote()));
+ if (!isPostgresql) {
Review comment:
Maybe we can remove this check. Because quote character can be set by
`kylin.source.quote.characte`, so user can set it to blank character or
double-quote character("), is it right ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
