[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113780#comment-17113780 ]
ASF GitHub Bot commented on KYLIN-3698: --------------------------------------- codecov-commenter commented on pull request #1227: URL: https://github.com/apache/kylin/pull/1227#issuecomment-632504460 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1227?src=pr&el=h1) Report > Merging [#1227](https://codecov.io/gh/apache/kylin/pull/1227?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/e7ab5dfd4431a5b410813311fa5e5a983e9aa4f2&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `0.71%`. [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1227/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/1227?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1227 +/- ## ============================================ - Coverage 24.87% 24.84% -0.04% - Complexity 6264 6265 +1 ============================================ Files 1453 1453 Lines 89125 89225 +100 Branches 12440 12456 +16 ============================================ - Hits 22174 22171 -3 - Misses 64774 64877 +103 Partials 2177 2177 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1227?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.12% <0.00%> (-0.04%)` | `44.00 <0.00> (ø)` | | | [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.44% <0.00%> (+0.23%)` | `2.00 <0.00> (ø)` | | | [...engine/mr/steps/ConvergeCuboidDataPartitioner.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQ29udmVyZ2VDdWJvaWREYXRhUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...lin/engine/mr/steps/FactDistinctColumnsMapper.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvRmFjdERpc3RpbmN0Q29sdW1uc01hcHBlci5qYXZh) | `5.17% <0.00%> (-0.05%)` | `0.00 <0.00> (ø)` | | | [...che/kylin/storage/hbase/steps/CreateHTableJob.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9DcmVhdGVIVGFibGVKb2IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...apache/kylin/storage/hbase/steps/CubeHFileJob.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9DdWJlSEZpbGVKb2IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ache/kylin/storage/hbase/steps/CubeHTableUtil.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9DdWJlSFRhYmxlVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [.../kylin/storage/hbase/steps/HFileOutputFormat3.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IRmlsZU91dHB1dEZvcm1hdDMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/storage/hbase/lookup/HBaseLookupRowEncoder.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9sb29rdXAvSEJhc2VMb29rdXBSb3dFbmNvZGVyLmphdmE=) | `92.59% <100.00%> (ø)` | `11.00 <0.00> (ø)` | | | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0.00%> (-3.41%)` | `8.00% <0.00%> (ø%)` | | | ... and [2 more](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1227?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1227?src=pr&el=footer). Last update [a471808...4538140](https://codecov.io/gh/apache/kylin/pull/1227?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > check-env.sh should print more details about checking items > ----------------------------------------------------------- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test > Affects Versions: v2.5.1 > Reporter: May Zhou > Assignee: Yaqian Zhang > Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)