[
https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142646#comment-17142646
]
ASF GitHub Bot commented on KYLIN-3698:
---------------------------------------
zhangayqian commented on a change in pull request #1222:
URL: https://github.com/apache/kylin/pull/1222#discussion_r443982825
##########
File path: build/bin/kylin.sh
##########
@@ -40,16 +40,10 @@ function retrieveDependency() {
source ${dir}/cached-hive-dependency.sh
source ${dir}/cached-hbase-dependency.sh
source ${dir}/cached-hadoop-conf-dir.sh
- source ${dir}/cached-kafka-dependency.sh
Review comment:
Because these three checks are put in check-env.sh, there is no need to
check them again here.
But now it is found that some tool commands, such as `bin/kylin.sh
org.apache.kylin.source.kafka.util.KafkaSampleProducer`, require Kafka's
dependency. However, the check-env.sh is not executed when using this command,
which makes it unable to load Kafka's dependency.
This is my negligence. It should not be removed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> check-env.sh should print more details about checking items
> -----------------------------------------------------------
>
> Key: KYLIN-3698
> URL: https://issues.apache.org/jira/browse/KYLIN-3698
> Project: Kylin
> Issue Type: Improvement
> Components: Tools, Build and Test
> Affects Versions: v2.5.1
> Reporter: May Zhou
> Assignee: Yaqian Zhang
> Priority: Minor
> Fix For: v3.1.0
>
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> In the current version, when users run _check-env.sh_, if there's no error
> message, it means everything is OK.
> From my perspective, adding more details about the checking items when
> executing check-env.sh is better.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
