zzcclp commented on a change in pull request #1259:
URL: https://github.com/apache/kylin/pull/1259#discussion_r455633685



##########
File path: 
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -1638,6 +1638,10 @@ public boolean isUseLocalClasspathEnabled() {
         return 
Boolean.parseBoolean(getOptional("kylin.engine.mr.use-local-classpath", TRUE));
     }
 
+    public int getTopNExtraSortRate() {
+        return 
Integer.parseInt(getOptional("kylin.engine.mr.topn-extra-sort-rate", "10"));

Review comment:
       IMO, set to 1 as default value and use the original way to merge, if 
user need to reduce count of sort, can set this property to a proper value by 
himself. Right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to