[
https://issues.apache.org/jira/browse/KYLIN-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256039#comment-17256039
]
ASF GitHub Bot commented on KYLIN-3392:
---------------------------------------
codecov-io commented on pull request #1524:
URL: https://github.com/apache/kylin/pull/1524#issuecomment-752141845
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1524?src=pr&el=h1) Report
> Merging
[#1524](https://codecov.io/gh/apache/kylin/pull/1524?src=pr&el=desc) (fe04ca8)
into
[master](https://codecov.io/gh/apache/kylin/commit/fe04ca8d3be6c50742246663d6fd6767a568bcf8?el=desc)
(fe04ca8) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1524?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1524 +/- ##
=========================================
Coverage 25.44% 25.44%
Complexity 6765 6765
=========================================
Files 1507 1507
Lines 93784 93784
Branches 13132 13132
=========================================
Hits 23867 23867
Misses 67533 67533
Partials 2384 2384
```
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/1524?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/1524?src=pr&el=footer). Last
update
[fe04ca8...16626be](https://codecov.io/gh/apache/kylin/pull/1524?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support NULL value in Sum, Max, Min Aggregation
> -----------------------------------------------
>
> Key: KYLIN-3392
> URL: https://issues.apache.org/jira/browse/KYLIN-3392
> Project: Kylin
> Issue Type: Bug
> Reporter: Yifei Wu
> Assignee: Yifei Wu
> Priority: Major
> Fix For: Future
>
> Attachments: KYLIN-3392-2.png, KYLIN-3392.png, kylin-3.0.0-alpha2.png
>
>
> It is treated as 0 when confronted with NULL value in KYLIN's basic aggregate
> measure (like sum, max, min). However, to distinguish the NULL value with 0
> is very necessary.
> It should be like this
> *sum(null, null) = null*
> *sum(null, 1) = 1*
> *max(null, null) = null*
> *max(null, -1) = -1*
> *min(null, -1）= -1*
> in accordance with Hive and SparkSQL
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
