[
https://issues.apache.org/jira/browse/KYLIN-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256223#comment-17256223
]
ASF GitHub Bot commented on KYLIN-3392:
---------------------------------------
kyotoYaho commented on a change in pull request #1524:
URL: https://github.com/apache/kylin/pull/1524#discussion_r549907811
##########
File path:
core-metadata/src/main/java/org/apache/kylin/metadata/datatype/BigDecimalSerializer.java
##########
@@ -47,8 +47,7 @@ public BigDecimalSerializer(DataType type) {
@Override
public void serialize(BigDecimal value, ByteBuffer out) {
if (value == null) {
- BytesUtil.writeVInt(0, out);
Review comment:
We cannot change the null check logic for backward compatibility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support NULL value in Sum, Max, Min Aggregation
> -----------------------------------------------
>
> Key: KYLIN-3392
> URL: https://issues.apache.org/jira/browse/KYLIN-3392
> Project: Kylin
> Issue Type: Bug
> Reporter: Yifei Wu
> Assignee: Yifei Wu
> Priority: Major
> Fix For: Future
>
> Attachments: KYLIN-3392-2.png, KYLIN-3392.png, kylin-3.0.0-alpha2.png
>
>
> It is treated as 0 when confronted with NULL value in KYLIN's basic aggregate
> measure (like sum, max, min). However, to distinguish the NULL value with 0
> is very necessary.
> It should be like this
> *sum(null, null) = null*
> *sum(null, 1) = 1*
> *max(null, null) = null*
> *max(null, -1) = -1*
> *min(null, -1）= -1*
> in accordance with Hive and SparkSQL
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
