[
https://issues.apache.org/jira/browse/KYLIN-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256772#comment-17256772
]
ASF GitHub Bot commented on KYLIN-4813:
---------------------------------------
zzcclp commented on a change in pull request #1525:
URL: https://github.com/apache/kylin/pull/1525#discussion_r550371200
##########
File path:
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -206,12 +207,15 @@ protected Properties getProperties(Collection<String>
propertyKeys) {
}
protected StrSubstitutor getSubstitutor() {
- // env > properties
- final Map<String, Object> all = Maps.newHashMap();
- all.putAll((Map) properties);
- all.putAll(System.getenv());
+ return new StrSubstitutor(getPropertiesMap());
+ }
- return new StrSubstitutor(all);
+ protected Map<String, Object> getPropertiesMap() {
+ if (propertiesMap.isEmpty()) {
+ propertiesMap.putAll((Map) properties);
+ propertiesMap.putAll(System.getenv());
+ }
Review comment:
When calling 'getPropertiesMap()' at the first time, it put all values
of properties and System.getenv() into propertiesMap, but if there are some
values be changed, the values in propertiesMap cann't be changed too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refine spark logger for Kylin 4 build engine
> --------------------------------------------
>
> Key: KYLIN-4813
> URL: https://issues.apache.org/jira/browse/KYLIN-4813
> Project: Kylin
> Issue Type: Improvement
> Affects Versions: v4.0.0-alpha
> Reporter: Xiaoxiang Yu
> Assignee: Yaqian Zhang
> Priority: Major
> Fix For: v4.0.0-beta
>
>
> - Separate spark log from kylin log
> - Store driver/executor log into HDFS.
> - Provided a API to view driver log.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
