[
https://issues.apache.org/jira/browse/KYLIN-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293764#comment-17293764
]
ASF GitHub Bot commented on KYLIN-4780:
---------------------------------------
lgtm-com[bot] commented on pull request #1596:
URL: https://github.com/apache/kylin/pull/1596#issuecomment-788972809
This pull request **introduces 4 alerts** when merging
6ba193cb466e6ce8616ff9b4bfb24d16d6fd6779 into
9d7ee863304220c5fb53a4c88cb798ed3edb0891 - [view on
LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-693112c1ebace325e1bd8af369c27fb474fff390)
**new alerts:**
* 3 for Dereferenced variable may be null
* 1 for Boxed variable is never null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor AbstractExecutable to extract the notification relevant business
> logic into a single component
> -------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-4780
> URL: https://issues.apache.org/jira/browse/KYLIN-4780
> Project: Kylin
> Issue Type: Improvement
> Components: Integration
> Reporter: vinoyang
> Assignee: chenjie
> Priority: Major
>
> Currently, Kylin supports mail service to know the change around the cube.
> However, there are some issues about the design, e.g.
> * AbstractExecutable contains an implementation of the mechanism of a
> notification listener, but only support mail service, it does not belong
> there;
> * The current implementation is hard to scale to other notification e.g.
> Ding Talk(which is a popular production supports by Alibaba)
> I propose to refactor the current implementation to extract the notification
> logic and redesign a new common notification/listener
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
