[
https://issues.apache.org/jira/browse/KYLIN-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295223#comment-17295223
]
ASF GitHub Bot commented on KYLIN-4780:
---------------------------------------
yanghua commented on a change in pull request #1596:
URL: https://github.com/apache/kylin/pull/1596#discussion_r587396384
##########
File path:
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -933,7 +933,7 @@ public String getHiveDependencyFilterList() {
+ "[^,]*hive-metastore[^,]*?\\.jar" + "|" +
"[^,]*hive-hcatalog-core[^,]*?\\.jar");
}
- public boolean isMailEnabled() {
+ public boolean isNotifyEnabled() {
Review comment:
IMO, `isNotificationEnabled` looks better?
##########
File path:
core-common/src/main/java/org/apache/kylin/common/notify/MailService.java
##########
@@ -40,8 +42,9 @@
private String password;
private String sender;
+
Review comment:
Revert these changes.
##########
File path:
core-common/src/main/java/org/apache/kylin/common/notify/MailService.java
##########
@@ -6,30 +6,32 @@
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
- *
Review comment:
Please do not change the unnecessary lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor AbstractExecutable to extract the notification relevant business
> logic into a single component
> -------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-4780
> URL: https://issues.apache.org/jira/browse/KYLIN-4780
> Project: Kylin
> Issue Type: Improvement
> Components: Integration
> Reporter: vinoyang
> Assignee: chenjie
> Priority: Major
>
> Currently, Kylin supports mail service to know the change around the cube.
> However, there are some issues about the design, e.g.
> * AbstractExecutable contains an implementation of the mechanism of a
> notification listener, but only support mail service, it does not belong
> there;
> * The current implementation is hard to scale to other notification e.g.
> Ding Talk(which is a popular production supports by Alibaba)
> I propose to refactor the current implementation to extract the notification
> logic and redesign a new common notification/listener
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
