[
https://issues.apache.org/jira/browse/KYLIN-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304653#comment-17304653
]
ASF GitHub Bot commented on KYLIN-4780:
---------------------------------------
codecov-io edited a comment on pull request #1596:
URL: https://github.com/apache/kylin/pull/1596#issuecomment-799678944
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=h1) Report
> Merging
[#1596](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=desc) (b2a10f4)
into
[master](https://codecov.io/gh/apache/kylin/commit/02500818d85955b1125340eaa19ab88a634a5181?el=desc)
(0250081) will **decrease** coverage by `0.03%`.
> The diff coverage is `17.25%`.
[](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1596 +/- ##
============================================
- Coverage 25.42% 25.39% -0.04%
- Complexity 6765 6778 +13
============================================
Files 1508 1517 +9
Lines 93918 94195 +277
Branches 13158 13188 +30
============================================
+ Hits 23877 23919 +42
- Misses 67662 67892 +230
- Partials 2379 2384 +5
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
|---|---|---|---|
|
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| `12.43% <ø> (-0.04%)` | `51.00 <0.00> (ø)` | |
|
[...rg/apache/kylin/common/notify/DingTalkService.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvRGluZ1RhbGtTZXJ2aWNlLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[...va/org/apache/kylin/common/notify/MailService.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTWFpbFNlcnZpY2UuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[...pache/kylin/common/notify/NotificationContext.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTm90aWZpY2F0aW9uQ29udGV4dC5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[...e/kylin/common/notify/NotificationTransmitter.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTm90aWZpY2F0aW9uVHJhbnNtaXR0ZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[.../apache/kylin/common/notify/NotifyServiceBase.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTm90aWZ5U2VydmljZUJhc2UuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[...kylin/common/notify/util/MailTemplateProvider.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvdXRpbC9NYWlsVGVtcGxhdGVQcm92aWRlci5qYXZh)
| `50.00% <ø> (ø)` | `4.00 <0.00> (?)` | |
|
[...ylin/common/notify/util/NotificationConstants.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvdXRpbC9Ob3RpZmljYXRpb25Db25zdGFudHMuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[...rg/apache/kylin/rest/service/MigrationRuleSet.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y3ViZS1taWdyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9NaWdyYXRpb25SdWxlU2V0LmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...rg/apache/kylin/rest/service/MigrationService.java](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree#diff-Y3ViZS1taWdyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9NaWdyYXRpb25TZXJ2aWNlLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [47
more](https://codecov.io/gh/apache/kylin/pull/1596/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=footer). Last
update
[d1c99d7...b2a10f4](https://codecov.io/gh/apache/kylin/pull/1596?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor AbstractExecutable to extract the notification relevant business
> logic into a single component
> -------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-4780
> URL: https://issues.apache.org/jira/browse/KYLIN-4780
> Project: Kylin
> Issue Type: Improvement
> Components: Integration
> Reporter: vinoyang
> Assignee: chenjie
> Priority: Major
>
> Currently, Kylin supports mail service to know the change around the cube.
> However, there are some issues about the design, e.g.
> * AbstractExecutable contains an implementation of the mechanism of a
> notification listener, but only support mail service, it does not belong
> there;
> * The current implementation is hard to scale to other notification e.g.
> Ding Talk(which is a popular production supports by Alibaba)
> I propose to refactor the current implementation to extract the notification
> logic and redesign a new common notification/listener
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
