[
https://issues.apache.org/jira/browse/KYLIN-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318729#comment-17318729
]
ASF GitHub Bot commented on KYLIN-4780:
---------------------------------------
lgtm-com[bot] commented on pull request #1596:
URL: https://github.com/apache/kylin/pull/1596#issuecomment-817285664
This pull request **introduces 3 alerts** when merging
6969865ac4a94673a0ab7486f3378514d44417ba into
ca0801201a4a5b3a78dd6fac788cbc5bde7e2bbd - [view on
LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-af9ebce9e01c211192f35597bfb0dd1fbccfcada)
**new alerts:**
* 3 for Dereferenced variable may be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor AbstractExecutable to extract the notification relevant business
> logic into a single component
> -------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-4780
> URL: https://issues.apache.org/jira/browse/KYLIN-4780
> Project: Kylin
> Issue Type: Improvement
> Components: Integration
> Reporter: vinoyang
> Assignee: chenjie
> Priority: Major
>
> Currently, Kylin supports mail service to know the change around the cube.
> However, there are some issues about the design, e.g.
> * AbstractExecutable contains an implementation of the mechanism of a
> notification listener, but only support mail service, it does not belong
> there;
> * The current implementation is hard to scale to other notification e.g.
> Ding Talk(which is a popular production supports by Alibaba)
> I propose to refactor the current implementation to extract the notification
> logic and redesign a new common notification/listener
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
