[GitHub] [kylin] zheniantoushipashi commented on pull request #1626: [KYLIN-4554] validate filter condition on model saving

Mon, 12 Apr 2021 02:05:50 -0700 


zheniantoushipashi commented on pull request #1626:
URL: https://github.com/apache/kylin/pull/1626#issuecomment-817631218


   > Did you patch consider dynamic variable case? Like 
`date_str>='${start_date}' and date_str<'${end_date}'` .
   > 
   > 
![image](https://user-images.githubusercontent.com/14030549/114337497-c3077900-9b83-11eb-841b-d1d1f7135dc3.png)
   
   thanks for remindingļ¼Œ  When saving the model, use the start_date and 
end_date of a mock to replace sql, and then verify
   
   see the below test evidence
   
   
![image](https://user-images.githubusercontent.com/3105102/114369548-12b06980-9bb1-11eb-87bd-66eac7f5d0b9.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to