[GitHub] [kylin] zheniantoushipashi commented on pull request #1626: [KYLIN-4554] validate filter condition on model saving

Mon, 12 Apr 2021 20:47:47 -0700 


zheniantoushipashi commented on pull request #1626:
URL: https://github.com/apache/kylin/pull/1626#issuecomment-818409750


   retest this please 
   
   > Maybe we can make it more Robust?
   > 
   > I change your UT a little, by changing from `TRANS_ID` to 
`kylin_account.TRANS_ID`, and find a mistake.
   > 
   > ```java
   > deserialize.setFilterCondition("kylin_account.TRANS_ID = 1");
   > ```
   > 
   > Following is the debug mode, it indicates that 
`allSqlIdentifier.add(id.names.get(0));` return `kylin_account`, not column 
name.
   > 
   > 
![image](https://user-images.githubusercontent.com/14030549/114491289-f6600b80-9c48-11eb-9a89-53c4fd467b38.png)
   > 
   > I think it could be better implemented, am I right ?
   
   yes, you are right, should consider it  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to