[
https://issues.apache.org/jira/browse/KYLIN-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17319896#comment-17319896
]
ASF GitHub Bot commented on KYLIN-4554:
---------------------------------------
coveralls edited a comment on pull request #1626:
URL: https://github.com/apache/kylin/pull/1626#issuecomment-817287678
## Pull Request Test Coverage Report for [Build
7061](https://coveralls.io/builds/38755612)
* **0** of **46** **(0.0%)** changed or added relevant lines in **3**
files are covered.
* **24** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.02%**) to **28.07%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[core-job/src/main/java/org/apache/kylin/job/JoinedFormatter.java](https://coveralls.io/builds/38755612/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2FJoinedFormatter.java#L59)
| 0 | 6 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/service/ModelService.java](https://coveralls.io/builds/38755612/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FModelService.java#L189)
| 0 | 6 | 0.0%
|
[core-metadata/src/main/java/org/apache/kylin/metadata/util/ModelUtil.java](https://coveralls.io/builds/38755612/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Futil%2FModelUtil.java#L36)
| 0 | 34 | 0.0%
<!-- | **Total:** | **0** | **46** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/38755612/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L48)
| 8 | 61.67% |
|
[engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkCubingByLayer.java](https://coveralls.io/builds/38755612/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkCubingByLayer.java#L531)
| 16 | 0% |
<!-- | **Total:** | **24** | | -->
| Totals | [](https://coveralls.io/builds/38755612)
|
| :-- | --: |
| Change from base [Build 7060](https://coveralls.io/builds/38738752): |
-0.02% |
| Covered Lines: | 26705 |
| Relevant Lines: | 95137 |
---
##### 💛 - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Validate "filter condition" on model saving
> -------------------------------------------
>
> Key: KYLIN-4554
> URL: https://issues.apache.org/jira/browse/KYLIN-4554
> Project: Kylin
> Issue Type: Improvement
> Components: Metadata
> Reporter: Shao Feng Shi
> Assignee: Sun BiaoBiao
> Priority: Major
> Fix For: v4.0.0-GA
>
> Attachments: WechatIMG397.png
>
>
> When define a model, user can enter a filter condition (using to do data
> filtering on loading). While the system doesn't validate the filtering
> condition's syntax; Later when build the cube, the condition will be send to
> Hive, Hive may report an error on the syntax, but at that time, it is
> difficult to modify it.
> Â
> !WechatIMG397.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
