[jira] [Commented] (KYLIN-4554) Validate "filter condition" on model saving

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/KYLIN-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320661#comment-17320661
 ] 

ASF GitHub Bot commented on KYLIN-4554:
---------------------------------------

zheniantoushipashi commented on pull request #1626:
URL: https://github.com/apache/kylin/pull/1626#issuecomment-819194725


   I added all the columns of all tables to the validate collection,  I did 
verification in ut and integration tests,
   
   **test evidence**
   
   
![image](https://user-images.githubusercontent.com/3105102/114648145-e7dd2700-9d10-11eb-8f83-f2fdad1a26e3.png)
   
   
   
![image](https://user-images.githubusercontent.com/3105102/114648044-b7958880-9d10-11eb-8f2b-8836c9f50849.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Validate "filter condition" on model saving
> -------------------------------------------
>
>                 Key: KYLIN-4554
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4554
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Metadata
>            Reporter: Shao Feng Shi
>            Assignee: Sun BiaoBiao
>            Priority: Major
>             Fix For: v4.0.0-GA
>
>         Attachments: WechatIMG397.png
>
>
> When define a model, user can enter a filter condition (using to do data 
> filtering on loading). While the system doesn't validate the filtering 
> condition's syntax; Later when build the cube, the condition will be send to 
> Hive, Hive may report an error on the syntax, but at that time, it is 
> difficult to modify it.
>  
> !WechatIMG397.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)