mikemccand commented on a change in pull request #815: LUCENE-8213: Introduce
Asynchronous Caching in LRUQueryCache
URL: https://github.com/apache/lucene-solr/pull/815#discussion_r326565944
##########
File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
##########
@@ -448,13 +459,42 @@ void assertConsistent() {
}
}
+ // pkg-private for testing
+ // return the list of queries being loaded asynchronously
+ List<Query> inFlightQueries() {
+ lock.lock();
+ try {
+ return new ArrayList<>(inFlightAsyncLoadQueries);
Review comment:
I'm still confused about `lock` -- do we always hold the lock when checking
if query is already in the map? If so, we don't need a `ConcurrentHashMap`?
If not, why do we even have the `lock` since it is a `ConcurrentHashMap`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
