mikemccand commented on a change in pull request #815: LUCENE-8213: Introduce
Asynchronous Caching in LRUQueryCache
URL: https://github.com/apache/lucene-solr/pull/815#discussion_r327565812
##########
File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
##########
@@ -732,8 +774,16 @@ public ScorerSupplier scorerSupplier(LeafReaderContext
context) throws IOExcepti
if (docIdSet == null) {
if (policy.shouldCache(in.getQuery())) {
- docIdSet = cache(context);
- putIfAbsent(in.getQuery(), docIdSet, cacheHelper);
+ // If asynchronous caching is requested, perform the same and return
+ // the uncached iterator
+ if (executor != null) {
+ cacheAsynchronously(context, cacheHelper);
+ return in.scorerSupplier(context);
+ }
+ else {
+ docIdSet = cache(context);
Review comment:
I think this means async caching can be more efficient, because with single
threaded caching, multiple threads could do the work to try the cache the same
`Query`, with only one of them winning in the end, but with async caching, we
ensure only one search thread does the caching? So e.g. red-line QPS
(capacity) could be a bit higher with async, if queries are often duplicated at
once?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
