[ 
https://issues.apache.org/jira/browse/SOLR-13816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946363#comment-16946363
 ] 

Jonathan J Senchyna commented on SOLR-13816:
--------------------------------------------

[~hossman] I completely agree with you.  I initially put them where they are, 
due to the precedent already set in {{DisMaxParams}}, but it didn't feel right. 
 I like the suggestion of extending it with a new {{ExtendedDisMaxParams}} 
interface, as it is supposed to support all of the same parameters, as well as 
the extended ones.

Thanks for the background info on the private interface - I'm just getting back 
into Java and wasn't aware of the background behind those.  I was wondering 
myself why they didn't use a static import.

> eDismax: Missing Param Constants
> --------------------------------
>
>                 Key: SOLR-13816
>                 URL: https://issues.apache.org/jira/browse/SOLR-13816
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: query parsers
>            Reporter: Jonathan J Senchyna
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, DisMaxParams contains a mix of constants for both the DisMax and 
> eDisMax query parsers; several of the eDisMax parameters are missing though.  
> This is needed to properly add support in Spring Data Solr.  Specifically, 
> constants for the following are not defined:
>  * sow
>  * lowercaseOperators
>  * stopwords
>  * uf



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to