[
https://issues.apache.org/jira/browse/LUCENE-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958917#comment-16958917
]
Jason Gerlowski commented on LUCENE-9026:
-----------------------------------------
I'm not familiar with two-phase intersection, though I'll look into it to see
whether PostFilter is fully overlapped by that.
I'm equally happy with a getter- if you have reason to prefer that I'll take my
patch that direction. Though I'm curious what difference you see between the
two...Does the Lucene community steer users away from subclassing queries for a
particular reason? Or is there some more general aversion to {{protected}}
visibility?
> Make it easier to extend DocValuesTermsQuery
> --------------------------------------------
>
> Key: LUCENE-9026
> URL: https://issues.apache.org/jira/browse/LUCENE-9026
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Affects Versions: master (9.0)
> Reporter: Jason Gerlowski
> Priority: Minor
>
> The visibility of some of the fields in DocValuesTermsQuery make it difficult
> to efficiently subclass. Especially the "termData" instance variable, which
> is really core to the functioning of the class but is totally inaccessible
> from any sub-classes, forcing subclasses to store a duplicate
> PrefixCodedTerms object, and then juggle the state of both.
> Are there any objections to making "termData" (and potentiall some other
> instance variables) protected instead of private for this class?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
