[
https://issues.apache.org/jira/browse/LUCENE-9026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971843#comment-16971843
]
Jason Gerlowski commented on LUCENE-9026:
-----------------------------------------
I've committed this on master and branch_8x with some added Javadocs as Adrien
suggested. (Though admittedly the javadoc text doesn't give much information
that the method names don't already share.)
Closing this out accordingly. Thanks everyone for the reviews and feedback.
> Make it easier to extend DocValuesTermsQuery
> --------------------------------------------
>
> Key: LUCENE-9026
> URL: https://issues.apache.org/jira/browse/LUCENE-9026
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Affects Versions: master (9.0)
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Minor
> Attachments: LUCENESOLR-9026.patch
>
>
> The visibility of some of the fields in DocValuesTermsQuery make it difficult
> to efficiently subclass. Especially the "termData" instance variable, which
> is really core to the functioning of the class but is totally inaccessible
> from any sub-classes, forcing subclasses to store a duplicate
> PrefixCodedTerms object, and then juggle the state of both.
> Are there any objections to making "termData" (and potentiall some other
> instance variables) protected instead of private for this class?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
