mkhludnev commented on a change in pull request #1011: LUCENE-9031: Just highlight term intervals and its' combinations. URL: https://github.com/apache/lucene-solr/pull/1011#discussion_r347109012
########## File path: lucene/queries/src/test/org/apache/lucene/queries/intervals/TestIntervals.java ########## @@ -393,11 +400,16 @@ public void testNesting2() throws IOException { assertNull(getMatches(source, 0, "field1")); MatchesIterator it = getMatches(source, 1, "field1"); assertMatch(it, 6, 21, 41, 118); + assertNull("Conjunction intervals don't yield query so far. dunno y",it.getQuery()); Review comment: I don't feel like it's blocker. Since, now master just throws exception, and this PR at least highlight something, and actually quite a lot. It seems like highlighting grasps into terms intervals well. From the other side, if it returns something like plain BQ of TQ, it might cause more coarse highlighting, or you propose to return IntervalQuery here? Thanks for your suggestions above. I'm completely lost in this tunnel. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org