iverase commented on issue #1040: LUCENE-9067: Polygon2D#contains is now thread safe URL: https://github.com/apache/lucene-solr/pull/1040#issuecomment-558979860 I am unsure how to apply bitwise logic using a java enum. Maybe I am missing something but creating an enum and adding my own bitwise logic seems inefficient: ``` ||Approach||Shape||M hits/sec ||QPS ||Hit count || ||Dev||Base ||Diff||Dev||Base||Diff||Dev||Base||Diff|| |points|polyRussia|12.67|12.76|-1%|3.61|3.64|-1%|3508846|3508846| 0%| |points|poly 10|58.95|57.79| 2%|37.28|36.54| 2%|355809475|355809475| 0%| |points|polyMedium|7.55|7.91|-5%|92.54|96.96|-5%|2693559|2693559| 0%| |shapes|polyRussia|6.78|7.00|-3%|1.93|2.00|-3%|3508846|3508846| 0%| |shapes|poly 10|30.97|32.91|-6%|19.58|20.81|-6%|355809475|355809475| 0%| |shapes|polyMedium|2.63|2.74|-4%|32.20|33.60|-4%|2693559|2693559| 0%| ``` On the other hand using a byte seems to speed up the computations: ``` ||Approach||Shape||M hits/sec ||QPS ||Hit count || ||Dev||Base ||Diff||Dev||Base||Diff||Dev||Base||Diff|| |points|polyRussia|14.68|13.11|12%|4.18|3.74|12%|3508846|3508846| 0%| |points|poly 10|60.77|59.54| 2%|38.43|37.65| 2%|355809475|355809475| 0%| |points|polyMedium|8.35|8.19| 2%|102.29|100.29| 2%|2693559|2693559| 0%| |shapes|polyRussia|7.33|5.36|37%|2.09|1.53|37%|3508846|3508846| 0%| |shapes|poly 10|32.80|33.14|-1%|20.74|20.95|-1%|355809475|355809475| 0%| |shapes|polyMedium|3.15|2.87|10%|38.62|35.14|10%|2693559|2693559| 0%| ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
