iverase commented on issue #1040: LUCENE-9067: Polygon2D#contains is now thread 
safe
URL: https://github.com/apache/lucene-solr/pull/1040#issuecomment-559025948
 
 
   I have rerun the performance tests for sanity check and using an enum 
instead of a byte slows down things. 
   
   I would stick to this approach for performance reasons even though it makes 
the code a bit more difficult to read. Still the logic is inside of the edge 
tree and not exposed to other objects.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to