[
https://issues.apache.org/jira/browse/SOLR-14095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe updated SOLR-14095:
-------------------------------------------------
Attachment: SOLR-14095-json.patch
Status: Open (was: Open)
Here is a patch using Noggit to serialize to Json. The problem with this
approach is that from the context of the code we don't know what's being
serialized. The "response" NamedList contains the responses that different
shards gave to the Overseer for the commands. It's not easy to use in this
case, it'll require a lot of work to serialize correctly, and I think it's not
worth it. Jackson wouldn't be better for the same reason, we don't know exactly
what's going to be in the response (and even worse, could change as Solr
evolves). The alternative if we want Json is to change how this code is being
used, but I believe that's out of the scope of this issue. I think we should go
with the Javabin approach for now, currently the serialization is Java native,
so it's unlikely that someone is using the content of the znode currently for
debugging/monitoring.
> Remove serialization and/or support serialization filtering
> -----------------------------------------------------------
>
> Key: SOLR-14095
> URL: https://issues.apache.org/jira/browse/SOLR-14095
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Robert Muir
> Priority: Major
> Attachments: SOLR-14095-json.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Removing the use of serialization is greatly preferred.
> But if serialization over the wire must really happen, then we must use JDK's
> serialization filtering capability to prevent havoc.
> https://docs.oracle.com/javase/10/core/serialization-filtering1.htm#JSCOR-GUID-3ECB288D-E5BD-4412-892F-E9BB11D4C98A
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
