noblepaul commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361019528
##########
File path: solr/core/src/java/org/apache/solr/core/PluginBag.java
##########
@@ -140,11 +139,10 @@ public static void initInstance(Object inst, PluginInfo
info) {
log.debug("{} : '{}' created with startup=lazy ", meta.getCleanTag(),
info.name);
return new LazyPluginHolder<T>(meta, info, core,
core.getResourceLoader(), false);
} else {
- if (info.pkgName != null) {
- PackagePluginHolder<T> holder = new PackagePluginHolder<>(info, core,
meta);
- return holder;
+ if (core.getResourceLoader().getPackage(info.pkgName) != null) {
Review comment:
Shouldn't we fail fast instead of continuing as if it there is no problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
