noblepaul commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361021966
##########
File path:
solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepositoryFactory.java
##########
@@ -71,7 +71,7 @@ public BackupRepository newInstance(SolrResourceLoader
loader, String name) {
PluginInfo repo = Objects.requireNonNull(backupRepoPluginByName.get(name),
"Could not find a backup repository with name " + name);
- BackupRepository result = loader.newInstance(repo.className,
BackupRepository.class);
+ BackupRepository result = loader.newInstance(repo, BackupRepository.class);
Review comment:
no thought given to reload
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
