dsmiley commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361490021
##########
File path: solr/core/src/java/org/apache/solr/schema/IndexSchemaFactory.java
##########
@@ -62,7 +62,7 @@ public static IndexSchema buildIndexSchema(String
resourceName, SolrConfig confi
PluginInfo info = config.getPluginInfo(IndexSchemaFactory.class.getName());
IndexSchemaFactory factory;
if (null != info) {
- factory = config.getResourceLoader().newInstance(info.className,
IndexSchemaFactory.class);
+ factory = config.getResourceLoader().newInstance(info,
IndexSchemaFactory.class);
Review comment:
> am I supposed to make comments on what it does today?
Yes (agreed); and not the future.
> I never said SRL loading classes is "plain wrong
I'm glad to hear that. You made this statement immediately after what I
said, which was "It does! Woohoo! It's because all loading occurs via a
SolrResourceLoader in Solr and so that's where the focal point of the approach
in this PR is." So I thought you meant my most recent statement "was plain
wrong" vs some statement in some other comment thread (notice this thread
doesn't discuss versions). Can you see how I came to this interpretation?
I am working this week, albeit lightly BTW.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
