iverase commented on code in PR #16571:
URL: https://github.com/apache/lucene/pull/16571#discussion_r4411703367
##########
lucene/core/src/java/org/apache/lucene/index/SegmentMerger.java:
##########
@@ -147,8 +155,6 @@ MergeState merge() throws IOException {
mergeWithLogging(this::mergeNorms, segmentWriteState, segmentReadState,
"norms", numMerged);
}
- mergeWithLogging(this::mergeTerms, segmentWriteState, segmentReadState,
"postings", numMerged);
Review Comment:
I don't understand why we are changing the order of the merging here. Maybe
add a comment why we need terms to be done after doc values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
