dsmiley commented on a change in pull request #1151: SOLR-13890: Add
"top-level" DVTQ implementation
URL: https://github.com/apache/lucene-solr/pull/1151#discussion_r365344397
##########
File path: solr/core/src/java/org/apache/solr/search/TermsQParserPlugin.java
##########
@@ -92,22 +92,28 @@ Query makeFilter(String fname, BytesRef[] byteRefs) {
@Override
Query makeFilter(String fname, BytesRef[] byteRefs) {
// TODO Further tune this heuristic number
- return (byteRefs.length > 700) ? new
TopLevelDocValuesTermsQuery(fname, byteRefs) : new DocValuesTermsQuery(fname,
byteRefs);
+ return disableCacheByDefault((byteRefs.length > 700) ? new
TopLevelDocValuesTermsQuery(fname, byteRefs) : new DocValuesTermsQuery(fname,
byteRefs));
Review comment:
right here simply call docValuesTermsFilterTopLevel.makeFilter or
docValuesTermsFilterPerSegment.makeFilter. Yes, enum methods may refer to
other enums in the same enum :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
