mkhludnev commented on a change in pull request #1161: SOLR-12325 Added
uniqueBlockQuery(parent:true) aggregation for JSON Facet
URL: https://github.com/apache/lucene-solr/pull/1161#discussion_r365840526
##########
File path: solr/core/src/java/org/apache/solr/search/ValueSourceParser.java
##########
@@ -975,6 +976,13 @@ public ValueSource parse(FunctionQParser fp) throws
SyntaxError {
}
});
+ addParser("agg_uniqueBlockQuery", new ValueSourceParser() {
+ @Override
+ public ValueSource parse(FunctionQParser fp) throws SyntaxError {
Review comment:
Hello, @a-siuniaev. Thanks for the patch. Wouldn't you mind to explore
[Yonik's
idea](https://issues.apache.org/jira/browse/SOLR-12325?focusedCommentId=16649083&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16649083)
about overloading the same name with the different argument type (query)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
