a-siuniaev commented on a change in pull request #1161: SOLR-12325 Added
uniqueBlockQuery(parent:true) aggregation for JSON Facet
URL: https://github.com/apache/lucene-solr/pull/1161#discussion_r366787064
##########
File path: solr/core/src/java/org/apache/solr/search/FunctionQParser.java
##########
@@ -231,7 +232,59 @@ public String parseArg() throws SyntaxError {
return val;
}
-
+ /**
+ * Parse argument in the same way as parseArg() but also parse the argument
name
+ * if written in following syntax: argumentName=argument.
+ *
+ * @return Immutable entry with name as the key and argument as value. In
case where there's no name, key is null.
+ * @throws SyntaxError in case when argument is not ended by ) or ,
+ */
+ public SimpleImmutableEntry<String, String> parseNamedArg() throws
SyntaxError {
Review comment:
1. Agree.
2.
[Here](https://issues.apache.org/jira/browse/SOLR-12325?focusedCommentId=16649083&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16649083)
he said "I wish we had..." - i.e. it did't exist at least at that time. And I
can't find it now...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
