madrob commented on a change in pull request #1184: LUCENE-9142 Refactor IntSet
operations for determinize
URL: https://github.com/apache/lucene-solr/pull/1184#discussion_r369169779
##########
File path:
lucene/core/src/java/org/apache/lucene/util/automaton/SortedIntSet.java
##########
@@ -77,6 +88,7 @@ public void incr(int num) {
values[i] = num;
counts[i] = 1;
upto++;
+ stale = true;
Review comment:
Because it didn't track whether the cached hash code was stale and relied on
the caller to do it. I feel like it is more clear to manage it internally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
