msokolov commented on a change in pull request #1233: LUCENE-9202: refactor
leaf collectors in TopFieldCollector
URL: https://github.com/apache/lucene-solr/pull/1233#discussion_r374946362
##########
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
##########
@@ -69,6 +69,79 @@ public void setScorer(Scorable scorer) throws IOException {
}
}
+ private abstract class TopFieldLeafCollector extends
MultiComparatorLeafCollector {
Review comment:
Well it has many reliances on `TopFieldCollector`'s members, and is never
created on its own, so I think it's probably best as an inner class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
