dsmiley commented on a change in pull request #1191: SOLR-14197 Reduce API of
SolrResourceLoader
URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384869359
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -909,15 +907,9 @@ public CoreContainer getCoreContainer() {
/**
* Creates a new core and register it in the list of cores. If a core with
the
* same name already exists, it will be stopped and replaced by this one.
- *
- * @param dataDir the index directory
- * @param config a solr config instance
- * @param schema a solr schema instance
- * @since solr 1.3
*/
- public SolrCore(CoreContainer coreContainer, String name, String dataDir,
SolrConfig config,
- IndexSchema schema, NamedList configSetProperties,
- CoreDescriptor coreDescriptor, UpdateHandler updateHandler,
+ private SolrCore(CoreContainer coreContainer, String name, ConfigSet
configSet, CoreDescriptor coreDescriptor,
Review comment:
I dunno... it's just one detail of a great many details that might be said.
And when you document something you run the risk of reality changing from what
you documented and so need to keep in sync. _Shrug._
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
