dsmiley commented on a change in pull request #1191: SOLR-14197 Reduce API of
SolrResourceLoader
URL: https://github.com/apache/lucene-solr/pull/1191#discussion_r384911169
##########
File path: solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java
##########
@@ -128,19 +129,23 @@ public static NodeConfig fromFile(SolrResourceLoader
loader, Path configFile, Pr
}
/** TEST-ONLY */
- public static NodeConfig fromString(SolrResourceLoader loader, String xml) {
- return fromInputStream(loader, new
ByteArrayInputStream(xml.getBytes(StandardCharsets.UTF_8)), new Properties());
+ public static NodeConfig fromString(Path solrHome, String xml) {
+ return fromInputStream(
+ solrHome,
+ new ByteArrayInputStream(xml.getBytes(StandardCharsets.UTF_8)),
+ new Properties());
}
- public static NodeConfig fromInputStream(SolrResourceLoader loader,
InputStream is, Properties substituteProps) {
+ public static NodeConfig fromInputStream(Path solrHome, InputStream is,
Properties substituteProps) {
+ SolrResourceLoader loader = new SolrResourceLoader(solrHome);
Review comment:
I looked into this a bit tonight; I didn't consider the close-ability of
SRLs before. Apparently it's because of the embedded URLClassLoader which
_ought to_ be closed. This was discussed when it was made closeable in
https://issues.apache.org/jira/browse/SOLR-4791 and it seems to only affect
Windows practically speaking. The CoreContainer.shutdown method will close
it's resourceLoader which is fetched from this SolrXmlConfig. That's the
particular instance you comment on here. But I don't see that a Core's SRL
will get closed. Shrug; I dunno if I should try to address that in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
