[ https://issues.apache.org/jira/browse/SOLR-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058442#comment-17058442 ]
Munendra S N commented on SOLR-8306: ------------------------------------ [^SOLR-8306.patch] Thanks [~adhenderson] for the PR. I have attached the patch generated using your PR as I'm not sure if pre-commit build supported for PR. Finally, will merge the PR so that you can have the attribution Few minor changes * {{Changes.txt}} should go to 8.6 instead of 8.5 as release branch is cut and I think this fits in optimization than improvements based on recent email thread about categorization of issues * When expand.rows=0 scores won't be computed. So, {{maxScore}} would never be available even if score is requested, this should be fine but we might need to add this solr documentation https://lucene.apache.org/solr/guide/8_4/collapse-and-expand-results.html#expand-component > Enhance ExpandComponent to allow expand.hits=0 > ---------------------------------------------- > > Key: SOLR-8306 > URL: https://issues.apache.org/jira/browse/SOLR-8306 > Project: Solr > Issue Type: Improvement > Affects Versions: 5.3.1 > Reporter: Marshall Sanders > Priority: Minor > Labels: expand > Fix For: 5.5 > > Attachments: SOLR-8306.patch, SOLR-8306.patch, SOLR-8306.patch, > SOLR-8306_branch_5x@1715230.patch > > Time Spent: 10m > Remaining Estimate: 0h > > This enhancement allows the ExpandComponent to allow expand.hits=0 for those > who don't want an expanded document returned and only want the numFound from > the expand section. > This is useful for "See 54 more like this" use cases, but without the > performance hit of gathering an entire expanded document. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org