[ 
https://issues.apache.org/jira/browse/SOLR-14012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059141#comment-17059141
 ] 

Chris M. Hostetter commented on SOLR-14012:
-------------------------------------------

[~munendrasn] -  at a glance it seems ok, but it looks like there's still an 
int based {{getCardinality()}} in {{UniqueAgg.BaseNumericAcc}} that could just 
be deleted and all callers replaced with {{getLong()}} ?

(If there's some reason why we need both then i'd suggest refactoring 
{{getCardinality()}} to call {{getLong()}} and cast the result, and include a 
comment explaining what/why it exists.

> Different data type for unique aggregation and countDistinct
> ------------------------------------------------------------
>
>                 Key: SOLR-14012
>                 URL: https://issues.apache.org/jira/browse/SOLR-14012
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Munendra S N
>            Assignee: Munendra S N
>            Priority: Major
>         Attachments: SOLR-14012.patch, SOLR-14012.patch
>
>
> countDistinct value is long but unique aggregation's value is either long or 
> int depending on shard count



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to