[ 
https://issues.apache.org/jira/browse/SOLR-14012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059193#comment-17059193
 ] 

Munendra S N commented on SOLR-14012:
-------------------------------------

 [^SOLR-14012.patch] 
I have renamed it {{getLong}} to {{getNonShardValue}} to reflect about its 
usage. I had kept {{getCardinality}} as it is used by {{getShardValue}} and the 
value is used to assign initial size for {{ArrayList}} which needs to be {{int}}
With the latest patch, I have delegated {{getNonShardValue}} to 
{{getCardinality}} and then casting to long. I have added javadocs for  
{{getCardinality}} usage

> Different data type for unique aggregation and countDistinct
> ------------------------------------------------------------
>
>                 Key: SOLR-14012
>                 URL: https://issues.apache.org/jira/browse/SOLR-14012
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Munendra S N
>            Assignee: Munendra S N
>            Priority: Major
>         Attachments: SOLR-14012.patch, SOLR-14012.patch, SOLR-14012.patch
>
>
> countDistinct value is long but unique aggregation's value is either long or 
> int depending on shard count



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to