dsmiley commented on issue #1366: SOLR-14342: Optimize core loading order in SolrCloud. URL: https://github.com/apache/lucene-solr/pull/1366#issuecomment-601508721 The previous CoreSorter had a getCloudDescriptors method that called CoreContainer.getCores(). But there are no cores registered yet! It was a pitty because it was only calling this method to get the core descriptors... but of course the core descriptors should be the input to the CoreSorter and so it's silly to try to find them some other way. I think this demonstrated that the API to use CoreSorter was more complicated than it needed to be; CoreSorter should have exactly one method that CoreContainer needs to call.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
