[
https://issues.apache.org/jira/browse/LUCENE-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072034#comment-17072034
]
Dawid Weiss commented on LUCENE-9266:
-------------------------------------
bq. I'm not confident that running the java download class only on src releases
is simpler than running it out of our source checkout.
It isn't simpler but it doesn't add additional overhead whereas a call to javac
and java will be noticeable on each gradlew script invocation -- this is
something I would like to avoid...
bq. download the wrapper jar in exactly the version matching that of the git
revision the release was created with
When you're building a release package you know which exact version of gradle
(and the wrapper) you need so you can precompute the checksum, download URL and
put these in the build scripts (gradlew.*). I think it'd be best to explain
what I have in mind by showing a patch rather than explaining... but It's a
really busy time right now and I don't know when I'll have a minute to devote
to it.
I think what you did in the patch is great though. There are just small bits
missing that would make it functional already - the download tool's hash
validation so that it updates automatically on upgrades of the wrapper in the
repository.
> ant nightly-smoke fails due to presence of build.gradle
> -------------------------------------------------------
>
> Key: LUCENE-9266
> URL: https://issues.apache.org/jira/browse/LUCENE-9266
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Mike Drob
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Seen on Jenkins -
> [https://builds.apache.org/job/Lucene-Solr-SmokeRelease-master/1617/console]
>
> Reproduced locally.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
