shalinmangar commented on a change in pull request #1402: SOLR-12720 Deprecated Auto Add Replica in XML URL: https://github.com/apache/lucene-solr/pull/1402#discussion_r403454481
########## File path: solr/core/src/java/org/apache/solr/core/CloudConfig.java ########## @@ -50,6 +50,8 @@ private final String pkiHandlerPublicKeyPath; + public static final int DEFAULT_AUTO_REPLICA_FAILOVER_WAIT_AFTER_EXPIRATION = 120000; Review comment: Let's move this to OverseerTriggerThread because that's the only class which uses this constant. Maybe rename to `DEFAULT_AUTO_ADD_REPLICA_WAIT_FOR_SECONDS` and set it to `120`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
